Frank Schuler was a leading promoter of a tax deduction derided as a scam by prosecutors, senators and the IRS. Now he’s a senior adviser to the General Services Administration, which manages the federal government’s property.