It was sort of, we never saw him smoking as he was “trying to quit”, which was done because at the time smoking in movies had become a big no no. Constantine doesn’t try to quit and smokes like a chimney, because he knows his fate is not to die by cancer.