To be fair: If you are chaining ternary expressions, you deserve to suffer whatever pain the language happens to inflict upon you tenfold.
Why?
It’s perfectly readable.
It is sort of readable. A switch is “perfectly” readable for switching.
Match is even better, short and sweet.
Ternary expressions aren’t switches though
Which is exactly why you shouldn’t be using them in a situation that clearly calls for a switch.
In the given example I’d probably use a switch / match expression, but ternaries are usually more flexible than switches and I don’t think it’s an issue to write a nested ternary instead of if else statements.
ternaries are usually more flexible than switches
Which is bad for readability because the reader need to manually compute it to see whether it’s doing simple switching or not. Also it adds the question of “Why did the author use a nested ternary instead of a switch? Was it meant to do more but it got left out unintentionally?”
Yes, you need to read code to understand it. If else statements can also do the job of a switch, so the exact same argument applies.
There is usually a safer and more readable way to do what you want to do by chaining ternaries in most languages.
How is it unsafe?
Well, if you assume ternary operations work the same in PHP as in c and attempted to write the code demoed by this meme. You would end up with unexpected behavior. Maybe I should have said unexpected behavior instead of unsafe behavior.
PHP is the only language in existence with a left associative ternary operator. Ignoring PHP, the operator has worked exactly the same way for decades. And even PHP has now fixed the operator.
I don’t think it’s reasonable to avoid a very commonly supported pattern just because a single badly designed language implemented it wrong.
Okay, even if I give you the unexpected behavior point. The readability problem remains. Switch statements or tables will work just fine and are easier to read.
To be clear, I am fine with single ternary operations. I think nested ternary operations are harder to read and follow.
I agree you should use a switch where applicable, but ternaries are the expression equivalent of if-else statements. If I have two conditions and a default, and each branch simply evaluates to a value of the same type, I’ll probably just use a ternary.
I get hating on PHP is a meme, and the language certainly has faults, but I feel like it’s no more arbitrary than how JavaScript behaves. And just like JavaScript, if you follow modern standards and use a modern version, it’s a much better experience. The language is only as good as the programmer.
but I feel like it’s no more arbitrary than how JavaScript behave
This is not the flex you think it is.
I didn’t mean it as a flex. It was a commentary on how the most commonly used programming language in current days is just as flawed as the most commonly used programming language in the past (in web development). Bad programmers are going to write bad code, regardless of the language.
I’d like to think Typescript does a lot of heavy lifting where JS fails when it comes to web development. On the otherhand there is no fixing fundamental flaws in PHP.
Sure bad programmers write bad code, but if a language tolerates something so obviously janky via implicit unseen magic, it’s just encouraging bad practices. PHP makes this worse by tweaking core behaviours in weird and wacky ways that can easily lead to security vulnerabilities.
A high level language should make coding easier. If it doesn’t why not just code in assembly, or even build an ASIC? And no, allowing you to fuck yourself by accident isn’t making your life easier even if it seems simpler at the time you write the code.
Why not just use a good language though? Most of them are decent. It sounds like typescript is getting used a lot, at least - although it then gets turned into JavaScript for the browser.
Why not just use a good language though?
You don’t really have a choice when it comes to front end web dev, JS is almost the only option for programming languages that run in the browser.
Yes, there’s a lot of lock-in with JavaScript. The first step would be designing a Python-based browser or whatever and getting people to use it. I know less about PHP.
That was more of a “why if you had the option”. I’ve use JavaScript too for exactly this reason.
That’s why JS gets hates on just as much as PHP, if not more so these days as JS is fuckin everywhere!
JS is just popular because Google invests so much money into it to use it to make the web worse off.
The fault is the programmer for not using a switch statement.
“php doesn’t stop me from coding like a moron, therefore php sucks”
How about “php enables me to code like a moron”, or even better, "php breaks common conventions and forces me to think about every little detail and special edge case, slowing me down if I don’t want to accidentally ‘code like a moron’ "
Nested ternary operators emerge because of the lack of if/switch expressions (which is C fault), so they are “useful” (they shouldn’t be). However, PHP is the only language that treats it as left associative. This has 2 problems:
- You are forced to use parenthesis. Some (insane) people might do: (cond1) ? “A” : (cond2) ? “B” : “C” And it makes sense. Its ugly af, but it makes sense. But PHP now forces you to use more parethesis. It’s making you work more.
- It breaks convention. If you come from any other language and use ternary operators, you will get unexpected results. After hours of banging your head against the wall, you realize the problem. And now you have to learn a new edge case in the language, and what to do to actually use the language.
“But you shouldn’t use ternary operators anyway! Use if/switch/polymorphic dispatch/goto/anything else”
True, but still, the feature is there, and its bad. The fact that there are other alternatives doesn’t make the PHP ternary operator worse than other languages’ ternary operator.
PHP works against you. That’s the problem. The ternary operator is not a good example, since there are alternatives. But look at something so simple, so mundane like strpos.
If strpos doesn’t find returns
false
. Every other language returns -1. And if you then use this value elsewhere, PHP will cast it to 0 for you. Boom, your program is broken, and you have to stare at the screen for hours, looking for the error.“BuT yOU sHoUlD AlwAyS cHEcK tHe rETurN eRRor!”
And even if that’s true, if we all must check the return value, does PHP force you to do so? Like checked exceptions in Java? Or all the
Option
&Result
in Rust? throws, throws, throws… unwrap, unwrap, unwrap… (Many) people hate those featuresPHP works against you. And that’s why its bad.
Show us on this doll where php hurt you. Php is great, especially in the later versions. I rarely need to know the position of a substring in a string, most of the time
str_starts_with()
,str_ends_with()
andstr_contains()
is what I really need.
I say that php breaks math entirely, and is therefore bad. “” == null returns true null == [] returns true “” == [] returns false.
In more recent versions it gets worse, because it has 0 == “any text” return true, “any text” == true return true, and 1 == true return true So indirectly 1 = 0, and now math is more directly broken.
If you’re trying to directly compare different variable types in any language without strong typing, you’re going to have edge-case results which you might not expect.
My “coding like a moron” message still stands. PHP isn’t a strongly typed language and it doesn’t tell you off for trying stupid stuff like comparing a string with an int. Nor do other languages like JavaScript.
Also using duck typing fails against php is pretty funny when it’s being compared against JAVASCRIPT of all things.
I just tested these out out of curiosity.
0==“text” returns false in PHP 8.2 as I’d expect.The others make sense in the way that php juggles between types. An empty variable can type-juggle to null, but an array can’t be directly compared with a string.
(Although you wouldn’t really want to compare an array with a string, PHP just treats an array as greater than other variables. So weirdly, ([] > “”) == true.)
Just… don’t use ==? I haven’t used it in a few years.
But if you code like a moron the code should still behave as expected. People who code like this deserve a special place in hell, next to languages that behave like that.
Ever wondered about the
array_fill
function? It can be baffling. Try filling an array with a negative index:array_fill(-5, 4, 'test');
Many languages would throw an error, but PHP? It’s perfectly fine with this and you get an array starting at index -5. It’s like PHP is the Wild West of array indexing!
Well, many languages are perfectly ok with negative array indexes.
But all of those languages are either statically typed ones where you declare the boundings with the array, or php.
Absolutely, many languages do allow negative indices. The intriguing part about PHP, though, is that its ‘arrays’ are actually ordered maps (or hash tables) under the hood. This structure allows for a broader range of keys, like our negative integers or even strings. It’s a unique design choice that sets PHP apart and allows for some really interesting usage patterns. Not your everyday array, right?
I’ve been working with PHP for two years now (not by choice) but I still sometimes forget the weird behaviours these not-arrays cause. Recently I was pushing/popping entries in a queue and it fucked the indexing. I had programmed it like I would any other sane language and it wasn’t until I was stepping through the bug I realised I had forgotten about this.
I hate PHP for so many more reasons. It baffles me why anyone would think it was a good idea to design it this way. Thankfully my current job involves actively burning it down and preparing for its replacement.
You think that’s bad, just wait until you hear what C does
“Shot myself in the foot? No, no. I took out the whole leg.”
That’s C++ you’re thinking off.
Yeah, because casting everything to void* is so safe.
it was never an array to begin with!
This is not valid syntax as of 2020. PHP 8 fixed a lot of issue like this as well as a lot of function and variable type issues.
Also this was deprecated in PHP 7 (2015).
They deprecated nested ternaries?
Not nested but ‘Unparenthesized’
Also per the error message here is it working:
PHP Fatal error: Unparenthesized
a ? b : c ? d : e
is not supported. Use either(a ? b : c) ? d : e
ora ? b : (c ? d : e)
Sure, it’s counterintuitive, but so is not bracketing things in ternary operations.
that makes so much fucking sense
You know that programmers of other languages don’t have to find excuses for their tool constantly, right?
You don’t know many languages, huh?
deleted by creator
Hating on php is one of the reasons i left reddit. This is just people who don’t use php hating php for some reason. You can do dumb examples like this for any language. Low effort and funny for children.
Your feelings are valid. I wonder though, would you put up this level of defense for posts making fun of arbitrary parts of non PHP languages?
You are not your favorite language. And I find most criticisms of most languages to be very valid. I don’t think the intent of OP is to insult all PHP programmers. It’s okay to like a language that has problems. All languages do.
I’d wager prevalence is part of their problem. Jokes get tired after a while, but that doesn’t always mean they stop.
PHP, like any language, has its problems, but it seems to get poked at a lot more often. But making the same joke over and over has been a problem long before reddit was a thing.
PHP gets a totally disproportionate share of hate and that is the problem. Children like to dunk on PHP and a group mentality pushes it even more.
Maybe it does. Maybe it doesn’t. This is the first post I have seen pointing out a flaw in PHP on Reddit or Lemmy. If you ask me JavaScript gets it the worst out of all of the languages. I don’t see those guys whining.
What I will say is that the majority of PHP developers I interact with on this post has led me to believe that there is a number of PHP developers that take things way to personally that they really shouldn’t. Seriously you guys aren’t doing your language any favors. No one’s going to want to join the whine club.
Hey, I hate php AND javascript, and I’ve worked in both of them. :P
I took this more as a light-hearted poke at a silly edge case. As someone who used to build static analysis software for various languages, including PHP. This gets a chuckle out of me as it takes me back to having to deal with these exact types of edge cases.
The title of this post is calling php a “meme” did you read that part? Then it just uses some stupid ternary example no one does and that other languages exhibit so what is the point other than purely hating on php?
I used php for 2 years and I hate on it it’s not just people who’ve never used it
no clue what your point is.
The comment above claimed only people who never used PHP hate on it. The point was a counter claim to that.
Ok I can add another group to my list then: bad php developers
Good developers don’t get tribal about the tools they use
It makes them able to switch away from them for better ones
I use typescript now
deleted by creator
This entire thread is a tribal post that I had a problem with!! You don’t seem to understand this but I don’t care.
Pointing out what sucks in a language isn’t tribalism, calling people “bad developers” when they don’t like your tool on the other hand, …
Hard sell. Calling people you know nothing about “bad developers” because they don’t like your tool on the other hand, that was cringe as hell and just made you look like you somehow tied your self-worth to php. “If my tool gets criticized; that means I’m being criticized!”
If you don’t give in to that, you start to see “Oh, that bug wouldn’t have happened if I’d been using [x]” and you become a better developer
When a woodworker cuts iself with a bandsaw, people who do what you do scream “He’s a bad woodworker!”
And while they’re screaming, we invented guardrails
level 1: “this argument is worthless because you are stupid!”
level 300: “everyone who hates php is just an idiot tbh”
Just standard discourse from the php community
There are reasons to dislike a language, but there are no reasons to hate a language, certainly not one that is as ubiquitous as PHP. There’s no argument you could make for why someone hates a programming language.
Introducing bugs into code way more often than others with similarly skilled programmers is one good reason to hate it…
deleted by creator
Halp. I don’t understand how it went from step 2 to step 3.
It’s cause PHP associates the if-then-else pair only with its immediate “else” option, not with the entirety of the line.
Let’s go by parts.
$a == 1 ? "one" : $a == 2 ? "two" : $a == 3 ? "three" : "other"
Is $a equal to 1? If so, we’re “set” to the value on the left, which is
"one"
, if not then we’re set to the value on the right, which is. $a is not equal to 1, so we’re set to the right value,
.
This replaces the relevant part,
$a == 1 ? "one" : $a == 2
, with. So we’re left with:
$a == 2 ? "two" : $a == 3 ? "three" : "other"
Next, is $a equal to 2? If so, we’re set to
"two"
, if not we’re set to. The comparison is true, so we’re set to the value on the left,
"two"
. The relevant part here is$a == 2 ? "two" : $a == 3
only, so it replaces it with"two"
cause again, PHP is only associating with its immediate pair. So now we’re left with:"two" ? "three" : "other"
Finally, is
"two"
truthy? If so, we’re set to"three"
, if not we’re set to"other"
. Since"two"
is truthy we’re then left with"three"
.It’s super confusing for sure.
Thanks! I never worked with PHP but I understand your explanation. Making memes about languages is also about learning
Thank you for the great explanation, and for teaching me the word “truthy.”
Thank you!
Finally got it…
$a == 1 ? "one" : ( ( $a == 2 ? "two" : $a == 3 ) ? "three" : "other" )
because “two” is a truthy value?
Yep, any non empty string is truthy.
Wat.
Ah, I understand now. The expression is evaluated like this:
$a == 1 ? "one" : $a == 2 ? "two" : $a == 3 ? "three" : "other"
$a == 2 ? "two" : $a == 3 ? "three" : "other"
"two" ? "three" : "other"
"three"
@AlmightySnoo @dot20 hooooo 🤯!! Thank you for the solution! 🤓
If you think PHP is weird, go look up ZZT-OOP, the scripting language from Tim Sweeney’s first game.
(No, a scripting language for game characters doesn’t need integers. If you need to count, you can do that by moving blocks around on the game board. It’s halfway between LOGO and Minecraft.)
I would expect this from Javascript :S
ZZT came out in 1991. JavaScript didn’t exist for at least four years after that.
Now do CGI.
Please. I worked with it for five years and I still don’t understand it.
Why
To quote the guy who invented PHP:
“I don’t know how to stop it, there was never any intent to write a programming language […] I have absolutely no idea how to write a programming language, I just kept adding the next logical step on the way.”
Yes, PHP was originally meant to be a template language, like handlebars or thymeleaf, but kept on accumulating features along the way…
They didn’t think about which order ternaries should compute in when they coded the php interpreter