Google’s telling me Arizona is in mountain time. For all locations in mountain time, the service in question returns “MST” (and doesn’t adjust to “MDT” for part of the year or anything.)
But Arizona doesn’t observe daylight saving’s time like the rest of those in mountain time.
Now, if the service in question returned “America/Phoenix” for Arizona locations and “America/Denver” (I think that’s right) for mountain time locations outside of Arizona, our code would be as simple as whateverMethodInTheStandardLibraryConvertsToTimezone(dateTime, timezone). But as it is, we have to do something like whateverMethodInTheStandardLibraryConvertsToTimezone(dateTime, state == "AZ" ? "America/Phoenix" : {"MST":"America/Denver","CST":"America/Chicago",...}[timezone]).
Also, I should mention we only have to deal with U.S. states plus Puerto Rico where I work. No UTC+8:45 timezones come into play or anything, at least. Also no locations in, say, the Navajo nation in Arizona currently.
I missed a few words so the first sentence was especially hard to understand.
Honestly, I’d just add a column to your locations table to store the time zone and don’t use google’s service. If you have a store in Gilbert, AZ, set this column to America/Phoenix. Minneapolis would get America/Chicago etc.
Ha! I think you’re still misunderstanding me. (Maybe misunderstanding me more than you were previously.)
We’re not using any Google service in relation to the timezones things in question. You said in your post “They shouldn’t be returning MNT for Arizona because they aren’t in Mountain time.” The only reason I mentioned Google is because after reading that sentence, I googled to see what timezone Arizona is in (because I thought I remembered it was in mountain time) and my Google search seems to confirm that Arizona is indeed in the mountain time zone.
If you have a store in Gilbert, AZ, set this column to America/Phoenix. Minneapolis would get America/Chicago etc.
Exactly what I’m getting at. They should be using the “America/Phoenix” format for identifying timezones, not “MST”. But they use the latter and I don’t have any control over the service in question because it’s owned by another team. We could nag them, but they don’t really have a lot of incentive to make such a fix, so realistically that task would probably die at the bottom of their backlog. My team only consumes data from the service in question. And because it’s doing things in that way, my team has to have extra complexity in our code to account for it.
The talk I’m planning to give to my team isn’t going to be related to any of that. My team also runs into timezone weirdness, of course, because so does every developer, and a better understanding about such things is definitely going to benefit everyone. That story about the other team using the three-letter abbreviations in stead of, say “America/Phoenix” was just me ranting about how things are done by other teams at the company where I work.
You should be bugging them every day to fix their data. Even if you have to call a new api that returns Olsen timezone names. That way you don’t break code that depends on existing internal timezone names.
Hmm?
Google’s telling me Arizona is in mountain time. For all locations in mountain time, the service in question returns “MST” (and doesn’t adjust to “MDT” for part of the year or anything.)
But Arizona doesn’t observe daylight saving’s time like the rest of those in mountain time.
Now, if the service in question returned “America/Phoenix” for Arizona locations and “America/Denver” (I think that’s right) for mountain time locations outside of Arizona, our code would be as simple as
whateverMethodInTheStandardLibraryConvertsToTimezone(dateTime, timezone). But as it is, we have to do something likewhateverMethodInTheStandardLibraryConvertsToTimezone(dateTime, state == "AZ" ? "America/Phoenix" : {"MST":"America/Denver","CST":"America/Chicago",...}[timezone]).Also, I should mention we only have to deal with U.S. states plus Puerto Rico where I work. No UTC+8:45 timezones come into play or anything, at least. Also no locations in, say, the Navajo nation in Arizona currently.
I missed a few words so the first sentence was especially hard to understand.
Honestly, I’d just add a column to your locations table to store the time zone and don’t use google’s service. If you have a store in Gilbert, AZ, set this column to America/Phoenix. Minneapolis would get America/Chicago etc.
Ha! I think you’re still misunderstanding me. (Maybe misunderstanding me more than you were previously.)
We’re not using any Google service in relation to the timezones things in question. You said in your post “They shouldn’t be returning MNT for Arizona because they aren’t in Mountain time.” The only reason I mentioned Google is because after reading that sentence, I googled to see what timezone Arizona is in (because I thought I remembered it was in mountain time) and my Google search seems to confirm that Arizona is indeed in the mountain time zone.
Exactly what I’m getting at. They should be using the “America/Phoenix” format for identifying timezones, not “MST”. But they use the latter and I don’t have any control over the service in question because it’s owned by another team. We could nag them, but they don’t really have a lot of incentive to make such a fix, so realistically that task would probably die at the bottom of their backlog. My team only consumes data from the service in question. And because it’s doing things in that way, my team has to have extra complexity in our code to account for it.
The talk I’m planning to give to my team isn’t going to be related to any of that. My team also runs into timezone weirdness, of course, because so does every developer, and a better understanding about such things is definitely going to benefit everyone. That story about the other team using the three-letter abbreviations in stead of, say “America/Phoenix” was just me ranting about how things are done by other teams at the company where I work.
You should be bugging them every day to fix their data. Even if you have to call a new api that returns Olsen timezone names. That way you don’t break code that depends on existing internal timezone names.