After some recent discussion on the topic of mutex poisoning and notably a blog post that I thought was interesting, thoughtful, exhaustive, yet completely disagreed with, I wanted to comment on the debate myself. To me, poisoning-by-default is one of biggest mistakes that were made in the language, next to some others that are a story for a different time.
It’s a good article and I agree, poisoning is a niche use case and shouldn’t be the default. That said it should document explicitly that it doesn’t handle panics in the critical section and that if you need that you should use a variant that does support poisoning. Basically the opposite of the situation as it currently exists where the default is poison with a note saying if you don’t need it use the non-poisoning (nightly only) version.