I was recently tasked with rewriting the base CSS for an inventory/project management system, creating a set of reusable components designed to match, using an open/close approach. These were based on a pretty strict specification provided by one of our designers, who unfortunately left.

The implementation went well, but I’ve run into a bit of a problem. Quite often the team members make changes directly to the base class in the new base CSS file, rather than extending it, creating a new one, or using each system area’s dedicated stylesheet file.

One of the more recent changes involved removing a grid-gap property from a rule from the base CSS, affecting a lot more than the single UI element the team member was working on.

Should I approach the team about this?

I haven’t mentioned anything yet, but have noticed our QA team putting in more bugs about UI elements looking odd

  • @fidodo
    link
    English
    310 months ago

    Do you have code review?

    • 𝒍𝒆𝒎𝒂𝒏𝒏OP
      link
      fedilink
      110 months ago

      We do, however they’re usually assigned to devs that are not familiar with the work carried out, thus these kinds of things end up slipping into the main branch…

      Looking at the other responses though this is something that I’ll need to raise with the team, some here have pointed out some pretty insightful stuff.

      • @fidodo
        link
        English
        210 months ago

        You may want to review your process then to make it clearer who should be on what review for different parts of the code base. You could use team groups to define who should be required for who.