Release v0.2.1-alpha.3+11 · hjiangsu/thunder
github.com
This is the third, and final pre-release of Thunder for v0.2.1+11! (if all things go accordingly and I don't mess up TestFlight builds again). There will most likely not be any more additions of fe...

This is the third, and final pre-release of Thunder for v0.2.1+11! (if all things go accordingly and I don’t mess up TestFlight builds again).

Edit 5: New pre-release to fix minor issues: https://github.com/hjiangsu/thunder/releases/tag/v0.2.1-alpha.9%2B11

Edit 4: New pre-release to fix issues with missing inbox items, and missing comments on profile/user page: https://github.com/hjiangsu/thunder/releases/tag/v0.2.1-alpha.8%2B11

Edit 3: New pre-release to fix issues with long comment chains above 8 not showing up: https://github.com/hjiangsu/thunder/releases/tag/v0.2.1-alpha.6%2B11

Edit 2: New pre-release to fix issues with replying from inbox: https://github.com/hjiangsu/thunder/releases/tag/v0.2.1-alpha.5%2B11

Edit 1: New pre-release to fix issues with comment editing: https://github.com/hjiangsu/thunder/releases/tag/v0.2.1-alpha.4%2B11

There will most likely not be any more additions of features for the next release, just bug fixes for large bugs. I would like to give a huge shoutout to everyone that has been working on PRs for this upcoming release, it has been incredible. This includes but is not limited to @bactaholic, @micahmo, @Fmstrat, @CTalvio, @ajsosa, @guigs4, @coslu, @minicit! Please let me know if I have missed anyone :D

Another note: I have created a Matrix space for Thunder for anyone who wants to have general chat there or to get replies even faster. The link to it is here: https://matrix.to/#/#thunderapp:matrix.org

Be fully prepared to know that these pre-release versions may contain major bugs which could cause Thunder to crash or behave unexpectedly.

For things to test out, I would suggest:

  • Test out everything you possibly can. Place heavy focus on general and most common actions (upvote, downvote, save, reply, comment, creating posts, etc)
  • Look around for any issues with performance overall, or things that seem like they require an immediate fix

Without further ado, these are the changes from the last pre-release:

  • Added initial way to block communities from the long press menu on posts. Long press a post in the feed page to show an option to block a community. Currently there is no way to unblock a blocked community, but that will come in a future release
  • Added a whole bunch of UI tweaks and changes to post page, and in other places - contribution from @CTalvio
  • Addition of community and user banners - contribution from @CTalvio
  • Added pull to refresh to a few more pages - contribution from @bactaholic
  • Showing collapsed comment count - contribution from @micahmo
  • Sharing media directly as images - contribution from @michahmo

…and probably a whole bunch of other under-the-hood changes I forgot to note down 😅

For a full changelog of things that have changed since the last release, visit this link: https://github.com/hjiangsu/thunder/blob/develop/CHANGELOG.md

  • @R51
    2•1 year ago

    Hi, looks like the matrix server is restricted for posting…

    Here are the issue I am still having:

    • Loading comments on profile page does not load any recent comments.

      • If I make a comment, it does not display on the thread when I click submit. So I can’t proofread it, let alone edit to fix any mistakes.
      • I posted a comment which didn’t show up, thought it failed to post and posted it again, and it still didn’t show neither on the thread nor the profile view. I opened up the web browser and deleted the duplicate comment from there.

    • Replies don’t show up / are very buggy in doing so. Clicking show all does not help. It’s like the client just gets a few replies to requests for data, sometimes.

    • This app feels so clean and I want this to be the one that lasts thru the ages so bad

    edit:

    • editing comments works so there’s that. On this post I was able to find my comment after posting. Maybe the issue is only when it’s nested? gonna try it out now
    • @darklightxiOPM
      2•1 year ago

      Replies don’t show up / are very buggy in doing so. Clicking show all does not help. It’s like the client just gets a few replies to requests for data, sometimes.

      This should hopefully be fixed with this build: https://github.com/hjiangsu/thunder/releases/tag/v0.2.1-alpha.7%2B11

      The main issue was that the inbox was only fetching x amount of items, and nothing more. I’ve added the ability for it to fetch more items when you scroll down

        • @R51
          1•1 year ago

          Sweet. I’m about to leave my computer so I’ll leave the screen record I took. I’ll check the updated app when I get a chance, but here’s what I had jotted down for the vid just in case cuz my original comment didn’t include some of it: https://libre.video/videos/watch/38ea4941-dac0-4528-bb77-34931e00814d

          0:00 - 0:25: child comment shows on Browser, but not in App’s Profile>Comments

          0:25 - 0:40: parent comment in Profile>Comments is clicked, Error screen, whole thread is loaded.

          0:40 - 1:20: adding 4th child to our comment thread. No bug now with this task, but still does not show in Profile>Comments

          1:20 - 1:40: shows bug with displaying Inbox>Replies.

          1. Click “Show All” and refresh, page gets populated.
          2. Refresh a second time, page is empty.
          3. Keep refreshing and page remains empty.
          4. To re-populate, must uncheck “Show All”, refresh, check “Show All”, then refresh.
          5. If refreshed once more, page will empty again.

          1:40 - 2:00: clicking a comment from this replies page also gives error. Does not scroll to / display reply for you to respond.

          2:00 - 3:00: more examples of the Inbox>Replies display issues

          3:00 - 4:45: I reply to a nested comment, prompt exits, comment I replied to replaced with spinner, and Disappears (“end of thread”).

          4:45 - 7:30: I reply to a nested (5th/6th?) comment. Entire thread below the spinner gets cut off.

          7:30 - 7:45: had to refresh the whole thread, scroll down, open nests, to find my comment

          7:45 - 8:00: still doesn’t show in Profile>Comments

          • @darklightxiOPM
            1•1 year ago

            Thanks for the detailed reply! I think most of the issues you’ve described should be fixed with the build I mentioned earlier

            • Profile > Comments should show all comments now
            • The error screen that you see briefly should be resolved
            • I’ve tested the inbox refresh stuff and it seems to be okay, but it could be on a case-by-cases basis
      • @R51
        2•1 year ago

        I am running the latest build published a few mins ago.

        I’ve narrowed down the culprit, I think…

        See this comment I made: https://lemmy.world/comment/982778

        From the app’s front page, from a post I clicked on the /c/, entered a thread, scrolled down to something with a few nests, and replied.

        After replied it just reloaded the whole thread, and doesn’t show up on my profile in the app. I had to get the link from the browser.

        Edit:

        • This comment also doesn’t show up.

        • When clicking the main comment from the profile page, I get an error, and it reloads this thread

        • From the profile page I saw your reply when checking “show all” and refreshing, but refreshing a 2nd time clears the whole list

        • @darklightxiOPM
          2•1 year ago

          Loading comments on profile page does not load any recent comments.

          The missing comments on the profile page is noted - this is the GitHub issue on it: https://github.com/hjiangsu/thunder/issues/249#issuecomment-1627488891

          If I make a comment, it does not display on the thread when I click submit. So I can’t proofread it, let alone edit to fix any mistakes.

          Just to clarify, the thread does not update when you press submit when entering a new comment? Does this happen to both the top-level comment (replying to a post) and also sub-comments (replying to replies/other comments)

          Replies don’t show up / are very buggy in doing so. Clicking show all does not help. It’s like the client just gets a few replies to requests for data, sometimes.

          I’ll take a closer look at the inboxing part to see what’s causing some of those issues. I probably won’t be able to get to all of them for this release, but I’ll see if I can fit some of them if they’re simple enough to figure out

          • @R51
            2•1 year ago

            This seems to be 4 or 5-nest deep so I’m recording this reply now.

            e: this reply seems to work fine, going to another nested