Add semantic ID's and classes to improve theming/userscript experience by Zetaphor · Pull Request #1327 · LemmyNet/lemmy-ui
github.com
There is currently a major lack of semantic ID's and classes in the UI markup. This makes everything from detecting if the site is running Lemmy (for userscript) to theming more difficult than nece...

Notably for this community is the inclusion of the “lemmy-site” class on the #app div

    • Zetaphor@zemmy.ccOPEnglish
      3·
      3 years ago

      That’s what kicked this whole thing off! I realized I was going to have to do all kinds of dumb stuff just to identify if I was actually looking at a lemmy site with any amount of certainty, and then it grew from there

        • Zetaphor@zemmy.ccOPEnglish
          1·
          3 years ago

          Please check the PR and let me know if there’s anything I missed as far as good candidates for CSS targeting. I tried to use a light touch while being mindful of the different ways people may want to style both visible and parent structures

          • CodingAndCoffeeEnglish
            1·
            3 years ago

            Here’s a few that would be helpful based on stuff I ran into in my userscript

            • Zetaphor@zemmy.ccOPEnglish
              3·
              3 years ago

              I just pushed a commit for the more-btn suggestion. The others look a bit more involved, but I think they are do-able. However I’m going to leave them for a separate PR as I would like this make sure this one gets into 0.18. That said I should be able to look into them next, just want to break this off and get it merged.

            • CodingAndCoffeeEnglish
              1·
              3 years ago

              Having all the various interaction buttons labeled, having a separate left-hand vs. right-hand footer location etc. would be helpful.

              Being able to have a link from a comment to scroll up to the parent or up to the root like HackerNews would be fantastic but is currently kinda difficult without a lot of looping (slow on big threads)

          • mershed_perderders@sh.itjust.worksMEnglish
            1·
            3 years ago

            the thing that bugged me (and continues to do so) is the different uses of .container-lg among the pages.

            It is used differently between the community, search, main, and alert/messages area and it killed me trying to figure out the spacing relative to each use. In some cases I gave up…