• @sandbox
    link
    285 months ago

    yeah I’m gonna go ahead and reject your PR, please change this function to accept a decimal value between 0 and 1

    • @ChickenLadyLovesLife
      link
      English
      125 months ago

      Ironically, the worst thing I ever saw a coworker do was to change a function that accepted an Integer value between 0 and 32767 to one that accepted a Float between 0.0 and 1.0. Perfectly sensible change except that it resulted in a 120 mph knuckleball fired a foot above a 10 year old kid’s head, followed by a fist fight between the client and my boss.

      • @jaybone
        link
        115 months ago

        That sounds like something that should have been caught by QA, integration tests or unit tests long before it was launching balls at ten year olds.

        • @ChickenLadyLovesLife
          link
          English
          65 months ago

          Yes, testing the new Little League control module on a field full of Little Leaguers was not the best plan.

          • @jaybone
            link
            35 months ago

            What is a little league control module?

            • @ChickenLadyLovesLife
              link
              English
              75 months ago

              You push a button and it makes Little Leaguers do whatever you tell them to do. Very potent, should never be misused.

      • @[email protected]
        link
        fedilink
        45 months ago

        yeah every engineer knows you gotta set KidHeadKnuckleballClearance waaay higher than that, it’s compsci 101