• bitwolf
    link
    fedilink
    English
    281 month ago

    It does warn you it will erase the file when you discard…

    • JackbyDev
      link
      fedilink
      English
      161 month ago

      Go read the actual thread. There was a bug someone found that files you have in there that aren’t even associated with git still get deleted. I’m not entirely convinced this was the poster’s fault.

      • @[email protected]
        link
        fedilink
        91 month ago

        It’s not a bug, it’s intentional. They consider changes to be any change since the last commit including in untracked files. They did update it to make this behavior a lot more obvious though.

          • @[email protected]
            link
            fedilink
            61 month ago

            Yes, honestly this situation reminds me a lot of the LTT trying Linux and destroying his system by installing steam despite apt warning him in the best way it really could that he probably didn’t want to do that. Sure the package shouldn’t have been in that state in a stable distro but shit happens. It goes to that point of, users will go through great lengths to achieve the end goal blindly jumping past warnings on the way no matter how dire they might be.

      • bitwolf
        link
        fedilink
        English
        11 month ago

        I did read the whole thread. I also referenced the resolution further down the comment thread.

        They’ve adjusted the error message to be abundantly clear after the fact.

    • @kalpol
      link
      151 month ago

      Warns you that changes will be discarded…not quite the same words

      • bitwolf
        link
        fedilink
        English
        -4
        edit-2
        1 month ago

        I just tried right now to get the exact message.

        Are you sure you want to DELETE foo?
        This is IRREVERSIBLE!
        This file will be FOREVER LOST if you proceed.

        The confirmation button even says Delete File

        User error.

        • @jas0n
          link
          151 month ago

          This issue was from 2017

          • bitwolf
            link
            fedilink
            English
            111 month ago

            Ah looking at issue 32459 it was addressed shortly after.

            You’re right that it did originally say “Discard”.

      • @[email protected]
        link
        fedilink
        -41 month ago

        If you use git and understand that VSC’s source control stuff is just a thin wrapper around git, you should understand what “discard all changes” means

        • JackbyDev
          link
          fedilink
          English
          7
          edit-2
          1 month ago

          “discard” is not a git operation. Reset and restore are, but those weren’t the words used.

          • @[email protected]
            link
            fedilink
            -21 month ago

            I’m not claiming that “discard” is a git action. I’m claiming a git user should understand what’s meant by the phrase “discard changes”. Run git status in a repo that has changes in the working directory. In the resulting output, there’s a message:

            Changes not staged for commit:
                (use "git add <file>..." to update what will be committed) 
                (use "git restore <file>..." to discard changes in working directory)
                    ...
            

            The phrase “discard changes” is used consistently in git’s output.

    • @SPRUNT
      link
      -31 month ago

      Man who clicks confirmation for leopards to delete his work is angry and surprised when his work is deleted.