• @[email protected]
    link
    fedilink
    11 day ago

    They aren’t saying never have complex boolean expressions…

    That’s not what I’m saying either. But I think this is to be judged on a case by case basis. And it can depend on your understanding of the context. I think there’s simply too much nuance here to just say “this smells”

    • @[email protected]
      link
      fedilink
      123 hours ago

      I disagree. I’ve seen very complex boolean expressions and they were clearly code smell. Sometimes acceptable but definitely a fertile area for refactoring.

      Their example is crap to be fair - two comparisons is not complex.

      • @[email protected]
        link
        fedilink
        122 hours ago

        If you do have a super complex boolean expression, I wouldn’t call it a smell. It’ll be much more obvious