Hello again, I’m in a situation where the one the senior devs on my team just isn’t following best practices we laid out in our internal documentation, nor the generally agreed best practices for react; his code works mind you, but as a a team working on a client piece I’m not super comfortable with something so fragile being passed to the client.

He also doesn’t like unit testing and only includes minimal smoke tests, often times he writes his components in ways that will break existing unit tests (there is a caveat that one of the components which is breaking is super fragile; he also led the creation of that one.) But then leaves me to fix it during PR approval.

It’s weird because I literally went through most of the same training in company with him on best practices and TDD, but he just seems to ignore it.

I’m not super comfortable approving his work, but its functional and I don’t want to hold up sprints,but I’m keenly aware that it could make things really messy whenbwe leave and the client begins to handle it on their own.

What are y’alls thoughts on this, is this sort of thing common?

  • @nitefox
    link
    171 year ago

    Last point is SO painful… I have a coworker that writes so much shitty code OR it straight up doesn’t work… he once submitted a PR that didn’t work when used! Like, I just started the thing and it was utterly broken - both the implementation and the design.

    More so, some of his PRs are a giant nightmare of over engineered crap that he, at some point, doesn’t even understand.

    Worst of all, he gets angry at me for pointing out that either they don’t work or they are a shitty, complex, mess

    Honestly, at some point I started approving his PR and calling it a day; oh we don’t have tests cause reasons, I tried to use TS too but since my boss finds it too complicated we are not using it again for new projects… funny

    • @BeepStreet
      link
      21 year ago

      This thread makes me so grateful for working with competent people.

      • @nitefox
        link
        21 year ago

        just yesterday I had to drop a lot of his commits cause they broke some core functionality lol

    • Josh
      link
      fedilink
      11 year ago

      @nitefox @glad_cat

      Pulling and at least trying to start the program when reviewing new hire code is fairly common for me. I don’t know what is, maybe a lack of experience, but I find newer programmers just assume their code works without trying it.

      You should always try your code. I’ve probably sent back hundreds of PRs because they just won’t even run.

      But I always send them back. They do learn, it just takes time.

      • @nitefox
        link
        11 year ago

        he has several yoe (more than me!) and he has been with us for at least two years…