Do you have any examples of the user history being jumbled up? Might be caused by the way the lemmy api returns user activity. If the page size is 10 results, it’s going to return 5 comments and 5 posts regardless of how recent they are.
The first page is mostly comments I made two weeks ago plus a thread from today and some very old threads. The second page has comments I made earlier today and during the past week. The third page starts with my most recent comment and then has a bunch of older comments.
The exact order might change after posting this, but my own recent comments mostly being on page two has been pretty consistent for a while.
If I look at a very active user’s profile (like MentalEdge’s), I see threads from today show up on page three(!) while there are threads from a week or more ago on pages one and two.
I’m not sure what’s going on exactly, but it basically makes user profiles pretty useless right now through mlmym.
Edit: I can’t even find this comment in my profile, but my other reply (regarding the envelope being fixed in 0.0.43) shows up on page 3.
looks like the default sort for the user history api changed in whatever version of lemmy reddthat is running. Fix in the latest mlmym release 0.0.44 accounts for that now!
Thanks! I’ll go ask Tiff about getting reddthat updated later.
BTW, is there a community for discussion of mlmym itself somewhere on lemmy? I can’t participate on GitHub, but those aren’t the only issues I’ve found. (e.g. there’s also ?format=jpg&thumbnail=96 on non-pictrs links and a text handling issue with angle brackets…)
I’m having trouble finding an example of the thumbnail issue again right now but I was seeing the pictrs conversion parameters passed to URLs from catbox.moe, i.postimg.cc, and other sources in the CSS for the thumbnail when I reported the issue to Tiff ~3 weeks ago. It’s possible that it got fixed/suppressed by another change since then though. (0.0.44 was deployed a few hours ago and I think there may have also been a beta patch bump for the lemmy backend at some point since I reported the issue originally in our local support community.)
I’ll let you know if I see it pop up again.
For the text handling issue, I was seeing text like “<thread title> by <username> in <community>” (i.e. "<threadtitle> by <username> in <community>" if it still happens) getting misinterpreted as raw HTML instead of being escaped. (i.e. <!-- raw HTML omitted --> was showing up in the HTML output for the page.)
You may recognize that text as the pattern for a recently fixed bug in the user profiles; I found the text handling issue while trying to explain the other issue to Tiff a few weeks ago.
Will edit this comment immediately after posting to let you know if I still see the text issue.
Note that it’s making a request to kbin.social with ?format=jpg&thumbnail=96 parameters in the CSS – which results in the full image being loaded since kbin doesn’t run pictrs.
The versions in use on reddthat (according to the settings page) are:
Do you have any examples of the user history being jumbled up? Might be caused by the way the lemmy api returns user activity. If the page size is 10 results, it’s going to return 5 comments and 5 posts regardless of how recent they are.
You can open any profile with multiple pages worth of posts or comments on old.reddthat.com and it’s jumbled. Even my own profile is jumbled: https://old.reddthat.com/u/e0qdk
The first page is mostly comments I made two weeks ago plus a thread from today and some very old threads. The second page has comments I made earlier today and during the past week. The third page starts with my most recent comment and then has a bunch of older comments.
The exact order might change after posting this, but my own recent comments mostly being on page two has been pretty consistent for a while.
If I look at a very active user’s profile (like MentalEdge’s), I see threads from today show up on page three(!) while there are threads from a week or more ago on pages one and two.
I’m not sure what’s going on exactly, but it basically makes user profiles pretty useless right now through mlmym.
Edit: I can’t even find this comment in my profile, but my other reply (regarding the envelope being fixed in 0.0.43) shows up on page 3.
Looks right here https://old.lemmy.world/u/[email protected]
looks like the default sort for the user history api changed in whatever version of lemmy reddthat is running. Fix in the latest mlmym release 0.0.44 accounts for that now!
Thanks! I’ll go ask Tiff about getting reddthat updated later.
BTW, is there a community for discussion of mlmym itself somewhere on lemmy? I can’t participate on GitHub, but those aren’t the only issues I’ve found. (e.g. there’s also
?format=jpg&thumbnail=96on non-pictrs links and a text handling issue with angle brackets…)no lemmy community for mlmym yet, that’s good idea.
do you have an example of that thumbnail issue?
I’m having trouble finding an example of the thumbnail issue again right now but I was seeing the pictrs conversion parameters passed to URLs from catbox.moe, i.postimg.cc, and other sources in the CSS for the thumbnail when I reported the issue to Tiff ~3 weeks ago. It’s possible that it got fixed/suppressed by another change since then though. (0.0.44 was deployed a few hours ago and I think there may have also been a beta patch bump for the lemmy backend at some point since I reported the issue originally in our local support community.)
I’ll let you know if I see it pop up again.
For the text handling issue, I was seeing text like “<thread title> by <username> in <community>” (i.e.
"<thread title> by <username> in <community>"if it still happens) getting misinterpreted as raw HTML instead of being escaped. (i.e.<!-- raw HTML omitted -->was showing up in the HTML output for the page.)You may recognize that text as the pattern for a recently fixed bug in the user profiles; I found the text handling issue while trying to explain the other issue to Tiff a few weeks ago.
Will edit this comment immediately after posting to let you know if I still see the text issue.
EDIT: I still see the text issue show up in this comment. https://old.reddthat.com/comment/10370610
I ran into an example of the thumbnail issue again today – this time on a post from kbin: https://old.reddthat.com/post/19193476
The thumbnail looks like this in the HTML:
Note that it’s making a request to kbin.social with
?format=jpg&thumbnail=96parameters in the CSS – which results in the full image being loaded since kbin doesn’t run pictrs.The versions in use on reddthat (according to the settings page) are:
lemmy: 0.19.4-beta.7
mlmym: 0.0.44
This kinda looks like an issue between lemmy and kbin. The issue is present on the lemmy ui as well. The
?format=jpg&thumbnail=96parameter being there doesn’t have an effect here. The issue is the thumbnail_url is reported wrong. You can see that here. The thumbnail_url should be: https://kbin.social/media/cache/resolve/entry_thumb/60/a4/60a45b8ff88b1b2e3a0f77b701feb323c5bbfb7ceeb75154ea7df5d6eea15ef8.jpg We could try and use some regex to lookout for kbin images and rewrite the thumbnail_url, but it should probably just be fixed upstream.Found this github issue which might be related: https://github.com/LemmyNet/lemmy/issues/3775