• AggressivelyPassive
    link
    fedilink
    298 months ago

    I have to say, I’m getting more and more frustrated by the bad code I have to write due to bad business circumstances.

    I want clean, readable code with proper documentation and at least a bit of internal consistency and not the shoehorned mess of hacks, todos and weird corner cases.

    • magic_lobster_party
      link
      fedilink
      138 months ago

      todos

      I found a simple trick against this: just remove them. Accept it ain’t gonna happen man.

      • AggressivelyPassive
        link
        fedilink
        58 months ago

        Well, yes, but the underlying issues still persist, so it’s not exactly a sustainable strategy.

        • magic_lobster_party
          link
          fedilink
          38 months ago

          It’s mostly a joke, but often when I find todos they’re so old they’re no longer relevant.

          Of course you shouldn’t blindly remove todos.

      • @[email protected]
        link
        fedilink
        1
        edit-2
        8 months ago

        Don’t just put “TODO”. If they’re in the final pull request, they need to mention a ticket that’s intended to fix that TODO. If you/your team decides it’s not important, then remove it and close out the ticket. Either way, you’re required to do something with it.

  • @[email protected]
    link
    fedilink
    68 months ago

    Instead of

    if let Some(a_) = a{
        ()
    } else if let Some(b_)=b{
        ()
    } else {
        dostuff 
    }
    

    you could just use

    if a.isNone()&&b.isNone(){
        dostuff
    }
    

    Also if you don’t use the value in a match just use _

      • @[email protected]OP
        link
        fedilink
        18 months ago

        I’m not sure how I would go about this in an elegant way since I’m matching the string I get from a message…

        • @[email protected]
          link
          fedilink
          17 months ago

          If the message used enums for actions/procedures like SPAM_MEMES, then using enums would be more performant

          • @[email protected]OP
            link
            fedilink
            27 months ago

            I think you’d be happy to know that I’ve gone for a bit of an overkill and used Pest to parse the commands, which automagically gets me an enum to match against in this position.

            The sad part is, I haven’t gotten the Media upload to work, so the project is on ice for a little while…

    • @[email protected]OP
      link
      fedilink
      28 months ago

      That’s a good point, thanks. Maybe I’ll go without the if entirely, the (janky) code is still very much in flux ;)

  • hswolf
    link
    28 months ago

    is this a section of a discord api implementation?

  • @6mementomori
    link
    17 months ago

    I don’t nearly know enough to understand this but is anyone willing to help me get the thing on the top :>