I had no idea this issue had been identified. While I find this tool very useful, the project is seeming rather questionable to me now.

  • ⸻ Ban DHMO 🇦🇺 ⸻
    link
    fedilink
    English
    416 hours ago

    I haven’t read to far into this but the issue is completely devoid of contributors and maintainers. I find the wording of the issue quite concerning:

    Due to the recent XZ-Utils drama I checked the code and I’m appalled. There are more BLOBS than source code. https://github.com/ventoy/Ventoy/tree/3f65f0ef03e4aebcd14f233ca808a4f894657802/cryptsetup https://github.com/ventoy/Ventoy/tree/3f65f0ef03e4aebcd14f233ca808a4f894657802/Unix/ventoy_unix https://github.com/ventoy/Ventoy/tree/3f65f0ef03e4aebcd14f233ca808a4f894657802/DMSETUP

    There is no reason to have those not be build in the release process. Of course it’s convenient, they are prebuild, it’s fast and nobody has a problem with it.

    Recent events however showed that these BLOBs can contain everything and nothing. The build instructions would not produce the exact same executable for everyone. It’s better to have GitHub build it on-push and use them out of the build cache.

    I would do it myself, but unfortunately I’m not familiar enough with the Ventoy build process to actually do it. I understand that removing BLOBs isn’t a priority over new and shiny features. But due to recent events, this should be rethought.

    Thank you for reading this and I hope for a productive conversation

    This is free software, they don’t owe you anything and this kind of language sounds angry and entitled. You can’t just Gordon Ramsay on someone else’s codebase.

    • @[email protected]
      link
      fedilink
      English
      233 minutes ago

      I cannot fathom what in this issue description gives rise to your concern. It’s worded very calmly, clearly explaining why the author thinks these BLOBs shouldn’t be there, expressing an understanding that it’s not a top priority and even closing with a thank you.

    • Wave
      link
      fedilink
      English
      79 hours ago

      I mean, people are allowed to have opinions. They may not be good opinions but thats the glory of opinions. You can Gordon Ramsey someone’s codebase, and someone else can Gordon Ramsey their comment, as you just did.

      • ⸻ Ban DHMO 🇦🇺 ⸻
        link
        fedilink
        English
        -16 hours ago

        I didn’t say they’re wrong it’s the way they communicated which I found off-putting and Gordon Ramsay -esque

    • @[email protected]
      link
      fedilink
      27 hours ago

      I mean the author has simply ignored this issue. If you look into it there are a few that people simply do not know how to generate, so without the maintainer it’s impossible to make a PR solving this.

      • ⸻ Ban DHMO 🇦🇺 ⸻
        link
        fedilink
        English
        -26 hours ago

        I mean if I got an issue that sounded that entitled and this is something I do in my spare time, I’d probably ignore it.

        My point is they could have worded it better and it might have gotten a response. If you ask kindly about the BLOBs and maybe for some help to push you in the right direction instead of saying “I don’t know”, then it is fair to call the maintainer rude for ignoring it completely.

  • Todd Bonzalez
    link
    fedilink
    211 day ago

    Anyone who wants to fix this can help fix it, but people are just making demands of an unpaid maintainer. The devs can run this project the way they want to. If you don’t like it, don’t use Ventoy.

    The people comparing this to the xz exploit are out of line. xz was a library that was deeply embedded in a lot of software. Ventoy is an IT tool used to boot live OSes. Not even remotely the same attack surface.

    Blobs in the source tree are not ideal, but people need to pick their battles.

    • Lemongrab
      link
      fedilink
      421 day ago

      From what others have said: The blobs violate GPL because they are taken from other FOSS project but the changes Ventoy makes are not viewable.

    • @[email protected]
      link
      fedilink
      61 day ago

      Little did they know that Patches the Cat bit through their LAN lines and actually increased the cost of their communication.

  • Mikelius
    link
    fedilink
    402 days ago

    Glad it’s getting a little more light. Been trying to tell people this for a few years now lol. It’s the reason I’ve stayed away from it since first learning of the tool and looking at the “source code”.

  • @Antagnostic
    link
    186
    edit-2
    2 days ago

    I was bored at work one day. I decided to put a nyan cat easter egg in my company’s app. If at the loading progress bar screen you typed NYAN it would turn the progress bar into a rainbow being created by a little nyan cat while playing the nyan cat song. The mp3 (inconspicuously renamed without the extension) doubled our build size. No one batted an eye cause no one paid attention to the build size much.

    Fast forward 5 years later, at a different job, I get a phone call from the old boss. Do you happen to know anything about this nyan cat file we found?

    I had no idea what he was talking about.

    • fmstrat
      link
      fedilink
      English
      522 days ago

      Years and years ago I worked on a project where the logo was the outline of a head and an inward swirl for the brain.

      For the website, if you held your mouse over it for 9 seconds, it would spin and flush. No one ever found that one that I know of.

      • @kautau
        link
        61 day ago

        It sounds like they weren’t using any form of version control, so that’s definitely on them at this point

        • @Alexstarfire
          link
          131 day ago

          What makes you say that? To me, it sounds like that’s what they do have cause they tracked the change back to him. The commit message obviously said nothing about the file.

          • @kautau
            link
            31 day ago

            Ah I could see that. I took it as them not knowing where the file came from at all, so they’re just asking all the devs who would have had access at that point, which is why it was “hey do you know anything about this file?” and not “is there a specific reason you committed this file to the build?”

            • @Alexstarfire
              link
              41 day ago

              You think they’d call up devs who left them just to ask if they happen to know about a random file?

  • @mashbooq
    link
    732 days ago

    After I saw that issue, I attempted to build Ventoy from source. After making numerous modifications and getting only the first couple components built, I got tired of it and quit. I’ve made some modifications to glim and use that instead, although it’s still not as easy as Ventoy. But I don’t trust Ventoy if I can’t build it myself.

    Further, when @[email protected] made some criticisms of Ventoy in one of her YouTube videos, she was subjected to a harassment campaign, and others told her the same happened to them. That pushed me from not trusting Ventoy to actively distrusting it.

    • Snot Flickerman
      link
      fedilink
      English
      402 days ago

      Further, when @[email protected] made some criticisms of Ventoy in one of her YouTube videos, she was subjected to a harassment campaign, and others told her the same happened to them.

      What the fuck is happening to the world? Are we regressing or were we always this regressed and we’ve just given powerful tools to fucking chowderheads?

      • @[email protected]
        link
        fedilink
        302 days ago

        There’s a subset of the Linux/FOSS/etc. community who are Conservative, misogynistic, racist, and/or otherwise general bigots. Compare the Ventoy-bros against the Elon-bros, and you’ll see a similar pattern of behavior.

        I don’t personally understand it, since development is still sometimes seen as “work for weirdo nerds,” so you’d think they would understand what it feels like to be rejected or bullied, but here we are. They manage to stay under the radar, because there’s usually no reason to discuss politics or philosophy when you’re debugging code.

        • Snot Flickerman
          link
          fedilink
          English
          22
          edit-2
          2 days ago

          There’s a subset of the Linux/FOSS/etc. community who are Conservative, misogynistic, racist, and/or otherwise general bigots.

          right, the hackernews set…

          • @[email protected]
            link
            fedilink
            242 days ago

            Don’t know why you’re being downvoted, hackernews is an awful site of smug, dumb software “engineer” tech bros with some of the worst takes on anything that isn’t explicitly about how to code

      • @[email protected]
        link
        fedilink
        5
        edit-2
        2 days ago

        It’s the other way around I think. We are progressing. More voices are heard which “should” be a good thing. Right? Right…?

        /s

  • @[email protected]
    link
    fedilink
    742 days ago

    I too wish the developer would respond, but I don’t think this is the catastrophe people are making it out to be. One comment seems to explain why these binaries are included:

    Because ventoy supports shim, and by extension secure boot, these files needs to come from a signed Linux distro. In this case they are taken from Fedora releases, and OpenSUSE apparently, as they publish shim binaries and grub binaries signed by their certificate.

    • @stickmanmeyhem
      link
      292 days ago

      If the hashes match the files from the Fedora or OpenSUSE releases, then does this really matter?

      • @[email protected]
        link
        fedilink
        English
        182 days ago

        It matters because nobody is going to check the hashes for all of the files match whenever there’s a change so the maintainer can just replace them with whatever he wants.

        • Pup Biru
          link
          fedilink
          English
          202 days ago

          that’s what automation is for - nobody is going to manually check them, but anyone is able to automatically set something up to check their hashes in change… the fact that it’s possible that anyone is doing that now that it’s a known issue perhaps makes it less problematic as an attack vector

          • @[email protected]
            link
            fedilink
            220 hours ago

            That is true, but also nobody is doing it. Just like nobody is verifying Signal’s “reproducible builds”.

            • Pup Biru
              link
              fedilink
              English
              312 hours ago

              are you sure?

              there could be thousands just waiting for a failure to come out and say “HEY THIS IS DODGY”

              • @[email protected]
                link
                fedilink
                1
                edit-2
                8 hours ago

                Yea because I tested it myself. Nobody else seems to care, and if they did, I would think there would be a public way to see regular test results regardless.

                I know this exists for some projects, but somehow nothing privacy-sensitive

          • @[email protected]
            link
            fedilink
            English
            11
            edit-2
            2 days ago

            The amount of malware you can cram in a source-code patch without drawing attention vs. in a binary is vastly different.

            There’s also the fact that if you want to ship binaries, you can just wget them from source during the build process. Not a perfect solution but much better than what’s ventoy doing. The source code updates works the same in every project because it has to. That’s why this is drawing more attention.

            • @[email protected]
              link
              fedilink
              3
              edit-2
              1 day ago

              That’s ok if we are talking about malware publicly shown in the published source code… but there’s also the possibility of a private source-code patch with malware that it’s secretly being applied when building the binaries for distribution. Having clean source code in the repo is not a guarantee that the source code is the same that was used to produce the binaries.

              This is why it’s important for builds to be reproducible, any third party should be able to build their own binary from clean source code and be able to obtain the exact same binary with the same hash. If the hashes match, then you have a proof of the binary being clean. You have this same problem with every single binary distribution, even the ones that don’t include pre-compiled binaries in their repo.

              • @[email protected]
                link
                fedilink
                18 hours ago

                The problem is not near enough projects support reproducible builds, and many that do aren’t being regularly verified, at least publicly.

    • @grue
      link
      English
      222 days ago

      On the contrary: that just goes to show what a fucking catastrophe for software freedom “Secure[sic] Boot” is.

    • @nialv7
      link
      152 days ago

      While this is true, it only requires the shim and grub to be copied for another distro.

      From other comments there are a lot more blobs than just these two.

      • davad
        link
        32 days ago

        It sounds like most, if not all, come from upstream projects.

        • @nialv7
          link
          317 hours ago

          Would be nice if the dev can respond and confirm that…

    • @[email protected]
      link
      fedilink
      92 days ago

      It sounds to me as a documentation issue, as the next comment says, simply including a wget script should solve this.

  • @[email protected]
    link
    fedilink
    English
    542 days ago

    Hey guys open source is great you can look at all the code and therefore there are no security backdoors etc. Also here are a bunch of pre-compiled blobs in the repo, don’t worry about those, but they are required to run the program.

    • snooggums
      link
      English
      852 days ago

      The fact that people know there are pre-compiled blobs in open source means they have an informed reason to avoid the software!

    • @[email protected]
      link
      fedilink
      162 days ago

      Right, the fact that it’s open is the reason this came to light, and we’re having this discussion

  • @[email protected]
    link
    fedilink
    English
    91 day ago

    I like multiboot. Used it back when I used Windows.
    The Ventoy advertisements on Reddit looked too suspicious, so I never checked it out.

  • @Feathercrown
    link
    English
    472 days ago

    God I hate people who use github comments for their own benefit. “Just fork it bro” is never helpful.

    • Sem
      link
      fedilink
      English
      272 days ago

      For me the problem is more in GPL violation: they distribute blobs under GPL3, user made a request of the source code by creating an issue, but they ignored that request. It is not only about “you have to fix it” versus “just fork it” imo.

    • @[email protected]OP
      link
      fedilink
      11 day ago

      I agree that comments like that are unhelpful/unnecessary, but how is that “for their own benefit”? Other than the actual devs themselves using that as a way to just ignore issues, I do not follow

      • @Feathercrown
        link
        English
        123 hours ago

        It makes them feel good and devalues the quality of discussion. Benefits them, harms others.

    • @friend_of_satan
      link
      English
      3
      edit-2
      2 days ago

      Seriously this. Any comment about a complicated system that starts with “just” can be ignored 99% of the time.

      Also, there are 4k forks of Ventoy already. Obviously forking it isn’t helping. Actual work needs to be done.

  • @[email protected]
    link
    fedilink
    302 days ago

    Makes me wonder how far the closest alternative, glim, could be upgraded to match Ventoy given the confines of GRUB.

    Someone had mentioned that Fedora fails to verify when booting from Ventoy. Now I’m thinking if I could dd the media loaded via Ventoy and compare with an original copy to see what changed.

  • LalSalaamComrade
    link
    fedilink
    English
    242 days ago

    Thank you for sharing this. I remember using Ventoy quite often back when I was still on Windows. I’ll be sticking with the good old dd command.