• Cralder
    link
    English
    523 months ago

    Bad naming practice. CheckSuck implies it only checks and returns the result. Everything the function does should be included in the name to avoid confusion. Call it SuckIfUnsucked or something

    • @[email protected]
      link
      fedilink
      73 months ago

      That was my first reaction as well. Even if you say you can see that it doesn’t return a bool it’s still ambiguus as to what (if anything) happens when the state is sucked/unsucked. I would also prefer a name like GuranteeSucked or EnsureIsSucked.