• @[email protected]
    link
    fedilink
    English
    43 days ago

    Surely we could optimize the return value with a switch statement and store the result as an integer to hide the compiler warning about our clearly correct code:

    internal static bool AreBooleansEqual(bool orig, bool val)
    {
        int result;
        if(orig) 
        {
            if(val)
            {
                result = 0;
            }
            else
            {
                result = 1;
            }
        }
        else
        {
            if(val)
            {
                result = 1;
            }
            else
            {
                result = 0;
            }
        }
        switch (result)
        {
             case(1):
                 return true;
             case(0):
                 return false;
             default:
                 return AreBooleansEqual(orig, val);
        }
    }
    

    New LOC: 35

    • @[email protected]
      link
      fedilink
      English
      22 days ago

      Make the input variables nullable, then add checks if the values are null, then assign default values if they are, otherwise continue with the passed values.

      • @Acters
        link
        English
        22 days ago

        Good idea but not feasible as that could introduce unknowns. Unfortunately making defaults when null is counterproductive as we are looking to increase LOC without introducing odd behavior and having no changes to how the overall function works. The only objective is to increase LOC.