Two wrongs don’t make a right, but sometimes in programming, two bugs can cancel each other out.
Whoever wrote this is more than capable of using it incorrectly.
Management: Gee whiz, we really have no idea how to gauge productivity to decide who gets promoted. We could manage. Or, better, we could just have someone write a script that pulls info from git on how many lines of code each person has written.
Programmers:
I promote based on lines of code removed.
I quit based on idiotic metrics
Is this part of Elons “How many lines of choice have you written?” interview?
Those are rookie lines of code numbers right there.
I would have done it without the==internal static bool AreBooleansEqual(bool orig, bool val) { if(orig) { if(val) return false return true } if(val) return true return false }Don’t know why their code returns false when they are equal but I’m not going to dig through old code to refactor to use true instead of false.
Sounds about right for a Java user.
Wait areBooleanEqual returns false when they are equal?
yesn’t
Don’t forget the invocation
if (CompareBooleans(a, b) == true)if (CompareBooleans(CompareBooleans(a, b), true))elseif(CompareBooleans(b,a) != false)
But how do you test for
FILE_NOT_FOUND?This is code after working 16 hours
I’d give my right hand this is a code review problem. Someone extracted a method returning true false. Then an intern came along and was told to refactor. They saw a lot of comparisons and “extracted” them.
My coworker made an array of book to express a status. This is no doing of an intern but a much eviler force at play.
I’ve heard of shared libraries, but this is ridiculous
There’s no way, that’s so insane it has layers.
At first, I thought the shitty methods were the joke 😱😱😱
Reminds me of is-even
I can definitely understand why they did that but it’s still very funny
Weekly downloads: 152,124
Have you seen the repository’s name (or rather the name of the owner of that repository) on github?
Shoot me now. Just get it over with. I can’t anymore.
GitHub page of this program:
I created this in 2014, when I was learning how to program.
I always figured it was a joke. I mean, it has another package called is-odd as a dependency. That’s comedy
My guess to why there’s two functions is because it was originally only
internal, and the programmer realized they neededpublicas well, but changinginternaltopublicis too scary so they created a new method instead.That does sound scary on general principles
You can tell they’re amateurs. It’s not obfuscated enough. They won’t be able to keep their job.
They clearly need an abstract boolean comparison factory.
var CompareBooleans = new ComparatorFactory().BooleanComparator(new BooleanComparisonByEqualityPolicy()); if (CompareBooleans(a, b) == true) { System.Out.PrintLn("Sames!!!"); }…
But now that I’ve written this, it’s C#, so it’s missing dependency injection.
I can imagine Uncle Bob be proud of this Clean Code ™
“We need to obfuscate our code to prevent reverse engineering”
The obfuscation in question:
We affectionately called it “subscurity” on the FE team.
When our BE apis would not give us any information why something failed, nor would they give us access to their logs. Complete black box of undocumented doodoo, and they would proudly say “security through obscurity” every time we asked why they couldn’t make improvements to usability.
You must have been working with the Redditors who told me that avoiding the use of JavaScript’s
eval()to parse JSON was a false sense of security.
Where are the unit tests?
