• Ephera
    link
    fedilink
    2803 months ago

    Tangentially related rant: We had a new contributor open up a pull request today and I gave their changes an initial look to make sure no malicious code is included.
    I couldn’t see anything wrong with it. The PR was certainly a bit short, but the task they tackled was pretty much a matter of either it works or it doesn’t. And I figured, if they open a PR, they’ll have a working solution.

    …well, I tell the CI/CD runner to get going and it immediately runs into a compile error. Not an exotic compile error, the person who submitted the PR had never even tried to compile it.

    Then it dawned on me. They had included a link to a GitHub Copilot workspace, supposedly just for context.
    In reality, they had asked the dumbass LLM to do the change described in the ticket and figured, it would produce a working PR right off the bat. No need to even check it, just let the maintainer do the validation.

    In an attempt to give them constructive feedback, I tried to figure out, if this GitHub Copilot workspace thingamabob had a Compile-button that they just forgot to click, so I actually watched Microsoft’s ad video for it.
    And sure enough, I saw right then and there, who really was at fault for this abomination of a PR.

    The ad showed exactly that. Just chat a bit with the LLM and then directly create a PR. Which, yes, there is a theoretical chance of this possibly making sense, like when rewording the documentation. But for any actual code changes? Fuck no.

    So, most sincerely: Fuck you, Microsoft.

    • @TrickDacy
      link
      533 months ago

      Surely you have to blame the idiot human here who actually has the ability to reason (in theory)

      • @[email protected]
        link
        fedilink
        563 months ago

        You think the decision to build this bot like that was not made by a human? Its idiot humans all the way down.

        • @TrickDacy
          link
          133 months ago

          Of course but people selling/offering shitty tool options is not only expected, it’s guaranteed. I certainly do not understand this tendency to blame the machine or makers of the machine and excuse the moronic developer

          • @[email protected]
            link
            fedilink
            10
            edit-2
            3 months ago

            Nono i agree with you, people like that cant be trusted with tying their shoes.

            I just wanted to point out that the system is the way it is because of “idiot human here who actually has the ability to reason”

          • Ethan
            link
            fedilink
            English
            43 months ago

            The person who uses the shitty tool is a moron. The person who makes the shitty tool is an asshole. At least in this case where the shitty tool is actively promoting shitty PRs.

          • @[email protected]
            link
            fedilink
            English
            33 months ago

            Responsibility is shared. It’s not one or the other.

            Many people don’t know what they’re doing. That’s kind of expected. But a tool provider and seller should know what they’re doing. Enabling people to behave in a negative way should be questioned. Maybe it’s a consequence of enablement, or maybe it’s bad design or marketing. Where criticism is certainly warranted.

            • @TrickDacy
              link
              -33 months ago

              Yes the only people ever to blame are everyone but the people who actually did a thing. That’s the same reason voters aren’t responsible for trump, Democrats are. /s

      • Ephera
        link
        fedilink
        113 months ago

        Well, for reasons, I happen to know that this person is a student, who has effectively no experience dealing with real-world codebases.

        It’s possible that the LLM produced good results for the small codebases and well-known exercises that they had to deal with so far.

        I’m also guessing, they’re learning what a PR is for the first time just now. And then being taught by Microsoft that you can just fire off PRs without a care in the world, like, yeah, how should they know any better?

      • @[email protected]
        link
        fedilink
        23 months ago

        ultimately the people responsible are the ones giving people tools that can be misused, you don’t hand a gun to a child.

          • @[email protected]
            link
            fedilink
            5
            edit-2
            3 months ago

            Oof.

            My employer pays a buttload bottomload of money to CircleCI - for extensive checks (build, lint, formatting, full test suite, as well as custom scripts for translation converage, docs,… for the full tech stack) on every push. Reviews start only when everything passes.

            I think you have given me a new-found appreciation for the reasoning behind that decision… 😄

    • @[email protected]
      link
      fedilink
      English
      16
      edit-2
      3 months ago

      Commit with Co-authored-by: Copilot

      or maybe better --author=Copilot

      It would certainly help evaluate submissions to have that context

  • @ilinamorato
    link
    1563 months ago

    We will never solve the Scunthorpe Problem.

  • oce 🐆
    link
    fedilink
    1313 months ago

    I had a Pycharm linter with “inconsiderate writing list” flag my use of “bi” as inappropriate, recommending to use “bisexual” instead. In my data job, BI, means business intelligence, it’s everywhere.

    • @dohpaz42
      link
      English
      703 months ago

      Those commit messages though 🤣

      • @jaybone
        link
        503 months ago

        They automated randomization of the commit messages? Wtf?

        • @ByteJunk
          link
          373 months ago

          Gotta appreciate the level of commitment on this commit…

    • @[email protected]
      link
      fedilink
      31
      edit-2
      3 months ago

      And they’re all with different commit message:

      “switched arse to bottom to create a more uplifting vibe”

      “took arse out and put bottom in to keep my language warm and friendly”

      “thought bottom would sound a lot nicer than arse, so I used it”

      And so on…

    • @[email protected]
      link
      fedilink
      English
      63 months ago

      The problem was named after an incident in 1996 in which AOL’s profanity filter prevented residents of the town of Scunthorpe, North Lincolnshire, England, from creating accounts with AOL, because the town’s name contains the substring “cunt”.

      haha

    • @hakunawazo
      link
      263 months ago

      Google: kill child process
      FBI: ಠ_ಠ

      Google: kill child process linux console
      FBI:(︶︿︶)

  • @brygphilomena
    link
    423 months ago

    I’ve been tempted to create a bot that does nothing but search comments in code for misspelled words and create pull requests for them.

    If it stays in comments, little chance in breaking a working codebase and I’d have an insane amount of commits and contributions to a wide variety of codebases for my resume.

    I’ll never be a top tier coder. But I might make management.

    • @Keenuts
      link
      283 months ago

      In case that wasn’t satire, please don’t 🥲 A small typo in a comment is not a big issue, and even if the PR is straightforward, a maintainer still has to take some time reviewing it, which takes time away from fixing actual bugs 😢

    • @[email protected]
      link
      fedilink
      33 months ago

      A better use of your time is to improve documentation. Developers generally hate documentation so it’s often in need of improvement. Rewrite confusing sentences. Add tutorials that are missing. Things like that. You don’t necessarily have to be a good developer or even understand the code of the project; you just have to have some knowledge of the project as an end user.

  • NumG
    link
    fedilink
    333 months ago

    I am in doubt. That wouldn’t even compile. But who am I to think somebody changing something like this would actually do a test compilation afterwards…

    • @[email protected]
      link
      fedilink
      43
      edit-2
      3 months ago

      HTML isn’t compiled, and unknown attributes are allowed. The best practice is to prefix non-standard attributes with data- (e.g. <div data-foo="test">) but nothing enforces that. Custom attributes can be retrieved in JavaScript or targeted in CSS rules.

    • Aa!
      link
      9
      edit-2
      3 months ago

      Compile? HTML?

      I’ve been off of web front end work for a while, but do CI systems actually do a “compile” type step on HTML these days?

      • NumG
        link
        fedilink
        23 months ago

        Yeah, you’re right. My mind was stuck. No compilation for HTML of course. I was thinking of automatic testing in CI systems after you commit. Compilation for Java, C++, etc.; some other form of testing for HTML (renaming tags like these should throw some errors I suppose)

        • Aa!
          link
          03 months ago

          At least linting, which if strong enough is close

    • @jaybone
      link
      123 months ago

      Or just have some random subset of browsers support them for some reason and other browsers not so much. It’s the html way.

  • @Valmond
    link
    293 months ago

    What is a ‘charset’ in this depraved persons mind? A corset? Must be a mighty kinky corset.

  • pflanzenregal
    link
    263 months ago

    OMG this took me way too long to get. They replace the substring “ass” 😭😭

    • @pyre
      link
      93 months ago

      and “arse”, as seen in charset